xxchan commented on code in PR #879:
URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1903316029


##########
crates/integrations/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -295,3 +303,129 @@ async fn test_table_predict_pushdown() -> Result<()> {
     assert!(s.value(1).trim().contains(expected));
     Ok(())
 }
+
+#[tokio::test]
+async fn test_metadata_table() -> Result<()> {
+    let iceberg_catalog = get_iceberg_catalog();
+    let namespace = NamespaceIdent::new("ns".to_string());
+    set_test_namespace(&iceberg_catalog, &namespace).await?;
+
+    let schema = Schema::builder()
+        .with_schema_id(0)
+        .with_fields(vec![
+            NestedField::required(1, "foo", 
Type::Primitive(PrimitiveType::Int)).into(),
+            NestedField::optional(2, "bar", 
Type::Primitive(PrimitiveType::String)).into(),
+        ])
+        .build()?;
+    let creation = get_table_creation(temp_path(), "t1", Some(schema))?;
+    iceberg_catalog.create_table(&namespace, creation).await?;
+
+    let client = Arc::new(iceberg_catalog);
+    let catalog = Arc::new(IcebergCatalogProvider::try_new(client).await?);
+
+    let ctx = SessionContext::new();
+    ctx.register_catalog("catalog", catalog);
+    let snapshots = ctx
+        .sql("select * from catalog.ns.t1$snapshots")
+        .await
+        .unwrap()
+        .collect()
+        .await
+        .unwrap();
+    check_record_batch(
+        snapshots[0].clone(),
+        expect![[r#"
+        Field { name: "committed_at", data_type: Timestamp(Millisecond, 
Some("+00:00")), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: 
{} },
+        Field { name: "snapshot_id", data_type: Int64, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} },
+        Field { name: "parent_id", data_type: Int64, nullable: true, dict_id: 
0, dict_is_ordered: false, metadata: {} },
+        Field { name: "operation", data_type: Utf8, nullable: false, dict_id: 
0, dict_is_ordered: false, metadata: {} },
+        Field { name: "manifest_list", data_type: Utf8, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} },
+        Field { name: "summary", data_type: Map(Field { name: "entries", 
data_type: Struct([Field { name: "keys", data_type: Utf8, nullable: false, 
dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "values", 
data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: 
{} }]), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, 
false), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }"#]],
+        expect![[r#"
+        committed_at: PrimitiveArray<Timestamp(Millisecond, Some("+00:00"))>
+        [
+        ],
+        snapshot_id: PrimitiveArray<Int64>

Review Comment:
   Currently the datafusion test cases don't have any data present so this is 
empty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to