xxchan commented on code in PR #879:
URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1903315532
##########
crates/integrations/datafusion/src/schema.rs:
##########
@@ -89,14 +87,43 @@ impl SchemaProvider for IcebergSchemaProvider {
}
fn table_names(&self) -> Vec<String> {
- self.tables.keys().cloned().collect()
+ self.tables
+ .keys()
+ .flat_map(|table_name| {
+ [table_name.clone()]
+ .into_iter()
+
.chain(MetadataTableType::all_types().map(|metadata_table_name| {
+ format!("{}${}", table_name.clone(),
metadata_table_name.as_str())
Review Comment:
The `$` syntax follows Flink
https://iceberg.apache.org/docs/1.5.2/flink-queries/#inspecting-tables instead
of `.` from Spark, because 4-level `catalog.schema.table.metadata` is not
supported in Datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
