Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133354991 ## crates/iceberg/src/transaction/mod.rs: ## @@ -25,31 +26,39 @@ use std::cmp::Ordering; use std::collections::HashMap; use std::mem::discriminant; use std::sync::

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133345927 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133304710 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133228521 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2133089713 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131841166 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131447271 ## crates/iceberg/src/transaction/snapshot.rs: ## @@ -72,16 +72,14 @@ pub(crate) struct SnapshotProduceAction<'a> { manifest_counter: RangeFrom, } -impl<'a> S

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131436989 ## crates/iceberg/src/transaction/append.rs: ## @@ -16,43 +16,45 @@ // under the License. use std::collections::{HashMap, HashSet}; +use std::sync::Arc; use ar

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131433406 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131433632 ## crates/iceberg/src/transaction/mod.rs: ## @@ -25,31 +26,39 @@ use std::cmp::Ordering; use std::collections::HashMap; use std::mem::discriminant; use std::sync::

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

ZENOTME commented on PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#issuecomment-2945140478 > Hi, @CTTY I think we should seperate our concerns here. Our design could be inspired by java, but it doesn't mean we should blindly copy java's class hierarchy. There are a lot of

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2128510336 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#issuecomment-2943607589 Hi, @CTTY I think we should seperate our concerns here. Our design could be inspired by java, but it doesn't mean we should blindly copy java's class hierarchy. There are a lot

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2127991210 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r212733 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r212733 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r212733 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#issuecomment-2942404607 Hi, Thanks for the feedback! I took another look at the transaction code path implementation in Java today and had some additional thoughts. - PendingUpdate#apply: - R

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

ZENOTME commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2126969179 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2126155800 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r212559 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2125576342 ## crates/iceberg/src/transaction/mod.rs: ## @@ -185,19 +195,111 @@ impl<'a> Transaction<'a> { /// Set the location of table pub fn set_location(mut self,

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2125486547 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

liurenjie1024 commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2123406121 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2118738013 ## crates/iceberg/src/transaction/action/mod.rs: ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2118723879 ## crates/catalog/memory/src/catalog.rs: ## @@ -277,12 +278,75 @@ impl Catalog for MemoryCatalog { } /// Update a table to the catalog. -async fn upda

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2118723879 ## crates/catalog/memory/src/catalog.rs: ## @@ -277,12 +278,75 @@ impl Catalog for MemoryCatalog { } /// Update a table to the catalog. -async fn upda

Re: [PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2118723879 ## crates/catalog/memory/src/catalog.rs: ## @@ -277,12 +278,75 @@ impl Catalog for MemoryCatalog { } /// Update a table to the catalog. -async fn upda

[PR] feat(WIP): Add TransactionAction [iceberg-rust]

CTTY opened a new pull request, #1400: URL: https://github.com/apache/iceberg-rust/pull/1400 ## Which issue does this PR close? Related Issues: - #1382 [EPIC] - #1386 - #1387 - #1388 - #1389 ## What changes are included in this PR? ## Are