CTTY commented on code in PR #1400:
URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2131436989
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -16,43 +16,45 @@
// under the License.
use std::collections::{HashMap, HashSet};
+use std::sync::Arc;
use arrow_array::StringArray;
+use async_trait::async_trait;
use futures::TryStreamExt;
+use futures::lock::Mutex;
use uuid::Uuid;
use crate::error::Result;
use crate::spec::{DataFile, ManifestEntry, ManifestFile, Operation};
use crate::transaction::Transaction;
+use crate::transaction::action::TransactionAction;
use crate::transaction::snapshot::{
DefaultManifestProcess, SnapshotProduceAction, SnapshotProduceOperation,
};
use crate::writer::file_writer::ParquetWriter;
use crate::{Error, ErrorKind};
/// FastAppendAction is a transaction action for fast append data files to the
table.
-pub struct FastAppendAction<'a> {
- snapshot_produce_action: SnapshotProduceAction<'a>,
+pub struct FastAppendAction {
+ snapshot_produce_action: Mutex<SnapshotProduceAction>,
Review Comment:
Made this `Mutex` because `snapshot_produce_action` has to be mutable when
calling `tx_action.commt`:
```
tx_action.commit(self: Arc<Self ...) {
self.snapshot_produce_action.(some function that will mutate
snapshot_produce_action)
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
