Xuanwo merged PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543915869
Thank you @c-thiel for working on this, and thank @Fokko, @liurenjie1024 and
@sdd for the review. We have waited for this for so long, let's move!
--
This is an automated message from
c-thiel commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543820634
@liurenjie1024 conflicts resolved. Had to slightly change a function
signature:
https://github.com/apache/iceberg-rust/pull/771/files#diff-8389535350ef7cddc266dfd18d589a978643da033
sdd commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543833200
Thanks @c-thiel, those comments are great, looks good to me :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sdd commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543368328
Hey all. I'm a bit late to the party on this one, but having taken a first
look after not having been closely involved in this, there's something that
struck me as being a little confusing
sdd commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1885410880
##
crates/iceberg/src/spec/partition.rs:
##
@@ -55,69 +52,43 @@ impl PartitionField {
}
}
-/// Partition spec that defines how to produce a tuple of partition va
liurenjie1024 commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543089808
cc @c-thiel Seems we need to fix conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Fokko commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2535647234
Gentle ping @liurenjie1024 so we can wrap up the 0.4.0 milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
c-thiel opened a new pull request, #771:
URL: https://github.com/apache/iceberg-rust/pull/771
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
