sdd commented on PR #771: URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543368328
Hey all. I'm a bit late to the party on this one, but having taken a first look after not having been closely involved in this, there's something that struck me as being a little confusing at first glance, and probably likely to confuse more people than me as the design discussions in here get stale over time and we're just looking at the code. Prior to this change, in `partition.rs`, we have a `BoundPartitionSpec` and a `SchemalessPartitionSpec`. It's pretty clear, if not from the names of these structs, then from the struct definitions themselves, what the difference is between the two. With this change though, we'll have `UnboundPartitionSpec` and `PartitionSpec`, which both have exactly the same shape - the distinction between these is not apparent at first glance for someone with fresh eyes or potentially even to future us after having not thought about this code for a while. Can we add some detail to the docstring for the definition of each that distinguishes each from the other? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
