c-thiel commented on PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#issuecomment-2543820634
@liurenjie1024 conflicts resolved. Had to slightly change a function
signature:
https://github.com/apache/iceberg-rust/pull/771/files#diff-8389535350ef7cddc266dfd18d589a978643da0334c23e16646e62e8d6a0892eR216-R219
@sdd thanks for the review! I fixed the typo and added a few comments.
```rust
/// Partition spec that defines how to produce a tuple of partition values
from a record.
///
/// A [`PartitionSpec`] is originally obtained by binding an
[`UnboundPartitionSpec`] to a schema and is
/// only guaranteed to be valid for that schema. The main difference between
[`PartitionSpec`] and
/// [`UnboundPartitionSpec`] is that the former has field ids assigned,
/// while field ids are optional for [`UnboundPartitionSpec`].
```
Let me know what you think! Feel free to extend if if you think more is
needed.
I like my previous names also more (SchemalessPartitionSpec). But as Python
and Java both call it `PartitionSpec`, it might be better to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
