zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2658229119
This is obsoleted by #40, though we haven't decided to adopt expected or
not, this PR can be closed. Thanks for all the inputs.
--
This is an automated message from the Apache Git Service
zhjwpku closed pull request #8: add Status data structure
URL: https://github.com/apache/iceberg-cpp/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
raulcd commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1913008941
##
src/iceberg/status.h:
##
@@ -0,0 +1,278 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTIC
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912677247
##
src/common/CMakeLists.txt:
##
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912676682
##
api/iceberg/status.h:
##
@@ -0,0 +1,435 @@
+// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style lice
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912674267
##
api/iceberg/util/string_builder.h:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.
lidavidm commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2581584623
I have used this before: https://github.com/TartanLlama/expected
I think my main complaint (this applies to Arrow too) is that the structure
is a bit opaque in a debugger. Arrow ende
zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2581582802
> I'm a bit late here but even if we want to use Status/Result, it may be
better to go with a backport of std::expected to at least try to align with the
STL.
>
> Ah sorry, I see dis
wgtmac commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2581569168
@lidavidm I was about to reply to this thread to revive the discussion :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lidavidm commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2581550186
I'm a bit late here but even if we want to use Status/Result, it may be
better to go with a backport of std::expected to at least try to align with the
STL.
--
This is an automated mess
zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2547351804
> I agree with @gaborkaszab that it would be better to discuss a concrete
API design (e.g. Table, FileIO, etc.) before introducing a full-functional
status implementation. If we decide to g
wgtmac commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2545814446
I agree with @gaborkaszab that it would be better to discuss a concrete API
design (e.g. Table, FileIO, etc.) before introducing a full-functional status
implementation. If we decide to go w
gaborkaszab commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2545642065
> There is an old stackoverflow question which I think we can take a look
There is a stackoverflow for everything and for the opposite too. I just
googled for "Status codes vs excepti
zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2543408428
> I think this PR makes too much assumptions that we will go with everything
that the Arrow community chose. For instance this seems to decide the
"exceptions vs status codes" question. Als
zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2543402219
> I think this PR makes too much assumptions that we will go with everything
that the Arrow community chose. For instance this seems to decide the
"exceptions vs status codes" question. Als
gaborkaszab commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2543336748
I think this PR makes too much assumptions that we will go with everything
that the Arrow community chose. For instance this seems to decide the
"exceptions vs status codes" question. A
pitrou commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884998853
##
api/iceberg/status.h:
##
@@ -0,0 +1,435 @@
+// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style licen
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884658885
##
api/iceberg/status.h:
##
@@ -0,0 +1,435 @@
+// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style lice
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884656709
##
src/common/CMakeLists.txt:
##
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
pitrou commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884153144
##
api/iceberg/status.h:
##
@@ -0,0 +1,435 @@
+// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style licen
pitrou commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884150547
##
api/iceberg/util/string_builder.h:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. S
pitrou commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884150163
##
CMakeLists.txt:
##
@@ -56,6 +64,11 @@ add_subdirectory(api)
add_subdirectory(src)
if(ICEBERG_BUILD_TESTS)
+ fetchcontent_declare(googletest
Review Comment:
Per
wgtmac commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884105549
##
src/common/CMakeLists.txt:
##
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
wgtmac commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884103063
##
api/iceberg/status.h:
##
@@ -0,0 +1,435 @@
+// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style licen
wgtmac commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1884094679
##
api/iceberg/util/string_builder.h:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. S
zhjwpku commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1883973801
##
CMakeLists.txt:
##
@@ -56,6 +64,11 @@ add_subdirectory(api)
add_subdirectory(src)
if(ICEBERG_BUILD_TESTS)
+ fetchcontent_declare(googletest
Review Comment:
Ye
zhjwpku commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2541489280
> Also @zhjwpku can you make sure you proof-read your PR description? There
are spell checkers that can help.
Sorry about the inconvenience, will be careful in the future.
--
This
pitrou commented on code in PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1883865597
##
CMakeLists.txt:
##
@@ -56,6 +64,11 @@ add_subdirectory(api)
add_subdirectory(src)
if(ICEBERG_BUILD_TESTS)
+ fetchcontent_declare(googletest
Review Comment:
Thi
pitrou commented on PR #8:
URL: https://github.com/apache/iceberg-cpp/pull/8#issuecomment-2541348036
Also @zhjwpku can you make sure you proof-read your PR description? There
are spell checkers that can help.
--
This is an automated message from the Apache Git Service.
To respond to the m
zhjwpku opened a new pull request, #8:
URL: https://github.com/apache/iceberg-cpp/pull/8
This is adpated from Apache Arrow, this is a pre step before integret the
Result data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
30 matches
Mail list logo
