Re: [PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-24 Thread via GitHub
sungwy merged PR #1187: URL: https://github.com/apache/iceberg-python/pull/1187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-20 Thread via GitHub
kevinjqliu commented on code in PR #1187: URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769271462 ## pyiceberg/manifest.py: ## @@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO, discard_deleted: bool = True) -> List ] +@cache

Re: [PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-20 Thread via GitHub
sungwy commented on code in PR #1187: URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769270495 ## pyiceberg/manifest.py: ## @@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO, discard_deleted: bool = True) -> List ] +@cached(ca

Re: [PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-20 Thread via GitHub
kevinjqliu commented on code in PR #1187: URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769269027 ## pyiceberg/manifest.py: ## @@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO, discard_deleted: bool = True) -> List ] +@cache

Re: [PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-20 Thread via GitHub
sungwy commented on code in PR #1187: URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769236181 ## pyiceberg/manifest.py: ## @@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO, discard_deleted: bool = True) -> List ] +@cached(ca

[PR] Use `cachetools's LRUCache` to cache manifest list [iceberg-python]

2024-09-20 Thread via GitHub
kevinjqliu opened a new pull request, #1187: URL: https://github.com/apache/iceberg-python/pull/1187 Closes #595, Reverts #787, Closes #1162 Reimplement manifest list cache as global cache, using only `manifest_list` as cache key -- This is an automated message from the Apache Git