sungwy commented on code in PR #1187:
URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769270495
##########
pyiceberg/manifest.py:
##########
@@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO,
discard_deleted: bool = True) -> List
]
+@cached(cache=LRUCache(maxsize=128), key=lambda io, manifest_list:
hashkey(manifest_list))
Review Comment:
That's so clever - so the issue was with the function arguments being 'held
up' by the cache preventing them from being GCed 🤯 ðŸ§
This is next level @kevinjqliu 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
