sungwy commented on code in PR #1187:
URL: https://github.com/apache/iceberg-python/pull/1187#discussion_r1769236181
##########
pyiceberg/manifest.py:
##########
@@ -620,6 +623,13 @@ def fetch_manifest_entry(self, io: FileIO,
discard_deleted: bool = True) -> List
]
+@cached(cache=LRUCache(maxsize=128), key=lambda io, manifest_list:
hashkey(manifest_list))
Review Comment:
Did the use of `cachetools` LRUCache, instead of `functools.lru_cache` solve
the issues with the FileSystem on M1 Macs we were observing before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
