Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-26 Thread via GitHub
zuyu closed pull request #24: Update cmake instructions in README URL: https://github.com/apache/iceberg-cpp/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912696116 ## .gitignore: ## @@ -16,6 +16,7 @@ # under the License. build/ +install/ Review Comment: > No, since we specify `CMAKE_INSTALL_PREFIX` in cmake, I think someon

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zuyu commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912645714 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTALL_P

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zuyu commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r191266 ## .gitignore: ## @@ -16,6 +16,7 @@ # under the License. build/ +install/ Review Comment: No, since we specify `CMAKE_INSTALL_PREFIX` in cmake, I think someone mig

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912577216 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTA

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912457864 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTALL

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-11 Thread via GitHub
lidavidm commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912383203 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTA

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-10 Thread via GitHub
wgtmac commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1911861722 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTALL

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-10 Thread via GitHub
zhjwpku commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1911797657 ## .gitignore: ## @@ -16,6 +16,7 @@ # under the License. build/ +install/ Review Comment: Why this? Is this generated by some IDE? ## README.md:

[PR] Update cmake instructions in README [iceberg-cpp]

2025-01-10 Thread via GitHub
zuyu opened a new pull request, #24: URL: https://github.com/apache/iceberg-cpp/pull/24 Build `Core Libraries` w/o `Arrow`, as there is another section about building `Iceberg Arrow Library` explicitly. -- This is an automated message from the Apache Git Service. To respond to the message