wgtmac commented on code in PR #24:
URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1911861722


##########
README.md:
##########
@@ -32,7 +32,7 @@ C++ implementation of [Apache 
Iceberg™](https://iceberg.apache.org/).
 
 ```bash
 cd iceberg-cpp
-cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/path/to/install 
-DICEBERG_BUILD_STATIC=ON -DICEBERG_BUILD_SHARED=ON
+cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/path/to/install 
-DICEBERG_BUILD_STATIC=ON -DICEBERG_BUILD_SHARED=ON -DICEBERG_BUILD_TESTS=OFF 
-DICEBERG_ARROW=OFF

Review Comment:
   Agreed. An official site for iceberg-cpp is more suitable for these 
documentations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to