Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

liurenjie1024 merged PR #558: URL: https://github.com/apache/iceberg-rust/pull/558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

liurenjie1024 commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1735524259 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,523 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1735144793 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -140,21 +140,79 @@ impl<'a> RowGroupMetricsEvaluator<'a> { return Ok(None);

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1735145149 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,1927 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1735144793 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -140,21 +140,79 @@ impl<'a> RowGroupMetricsEvaluator<'a> { return Ok(None);

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1735142271 ## crates/iceberg/Cargo.toml: ## @@ -83,5 +83,6 @@ ctor = { workspace = true } iceberg-catalog-memory = { workspace = true } iceberg_test_utils = { path = "../test_uti

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1734050618 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,1927 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

liurenjie1024 commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1733780815 ## crates/iceberg/Cargo.toml: ## @@ -83,5 +83,6 @@ ctor = { workspace = true } iceberg-catalog-memory = { workspace = true } iceberg_test_utils = { path = ".

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1731265175 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -140,21 +140,79 @@ impl<'a> RowGroupMetricsEvaluator<'a> { return Ok(None);

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1731258487 ## crates/iceberg/Cargo.toml: ## @@ -83,5 +83,6 @@ ctor = { workspace = true } iceberg-catalog-memory = { workspace = true } iceberg_test_utils = { path = "../test_uti

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

liurenjie1024 commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1731161779 ## crates/iceberg/Cargo.toml: ## @@ -83,5 +83,6 @@ ctor = { workspace = true } iceberg-catalog-memory = { workspace = true } iceberg_test_utils = { path = ".

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1729382056 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## Review Comment: Back to you, @liurenjie1024 - I've added tests to cover (hopefully!) all cod

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1725513822 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## Review Comment: Yep - in progress, should not take too long. -- This is an automated mess

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1725513366 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,523 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1725509998 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,523 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

Re: [PR] Table Scan: Add Row Group Skipping [iceberg-rust]

liurenjie1024 commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1721853381 ## crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs: ## @@ -0,0 +1,523 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or