liurenjie1024 commented on code in PR #558:
URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1733780815
##########
crates/iceberg/Cargo.toml:
##########
@@ -83,5 +83,6 @@ ctor = { workspace = true }
iceberg-catalog-memory = { workspace = true }
iceberg_test_utils = { path = "../test_utils", features = ["tests"] }
pretty_assertions = { workspace = true }
+rand = "0.8"
Review Comment:
In fact currently there is no explicit rule for this. I think current
convention we are following are…
1. If a lib is used by more than one crate, it should be in workspace.
2. For libs that are too specific to one crate, for example `sqlx` for sql
catalog.
I think the second rule is worth discussion, should we just simply put all
into workspace? cc @Xuanwo What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
