sdd commented on code in PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#discussion_r1731258487
########## crates/iceberg/Cargo.toml: ########## @@ -83,5 +83,6 @@ ctor = { workspace = true } iceberg-catalog-memory = { workspace = true } iceberg_test_utils = { path = "../test_utils", features = ["tests"] } pretty_assertions = { workspace = true } +rand = "0.8" Review Comment: Sure, will do. I was wondering, what exactly is our policy on this as I've not seen it written anywhere? Is it simply for all dependencies to have their details at the workspace level, and for package level cargo toml to only contain workspace = true? Or is there more to it? It might be helpful to add a comment in the cargo.toml for clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org