Re: [PR] Support loading custom catalog impl [iceberg-python]

kevinjqliu commented on PR #947: URL: https://github.com/apache/iceberg-python/pull/947#issuecomment-2251166250 @jackye1995 Done, thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Support loading custom catalog impl [iceberg-python]

kevinjqliu merged PR #947: URL: https://github.com/apache/iceberg-python/pull/947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ice

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on PR #947: URL: https://github.com/apache/iceberg-python/pull/947#issuecomment-2250898833 @HonahX @kevinjqliu any further comments? Could this be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Support loading custom catalog impl [iceberg-python]

kevinjqliu commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685524899 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685513070 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685512970 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685520033 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685519855 ## mkdocs/docs/configuration.md: ## @@ -139,7 +139,13 @@ For the FileIO there are several configuration options available: ## Catalogs -PyIceberg currentl

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685513070 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog

Re: [PR] Support loading custom catalog impl [iceberg-python]

jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685512970 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

kevinjqliu commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685511390 ## mkdocs/docs/configuration.md: ## @@ -139,7 +139,13 @@ For the FileIO there are several configuration options available: ## Catalogs -PyIceberg currentl

Re: [PR] Support loading custom catalog impl [iceberg-python]

HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

Re: [PR] Support loading custom catalog impl [iceberg-python]

HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

Re: [PR] Support loading custom catalog impl [iceberg-python]

HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322288 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No deleted

Re: [PR] Support loading custom catalog impl [iceberg-python]

HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322288 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No deleted

Re: [PR] Support loading custom catalog impl [iceberg-python]

HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

[PR] Support loading custom catalog impl [iceberg-python]

jackye1995 opened a new pull request, #947: URL: https://github.com/apache/iceberg-python/pull/947 Closes #938 @HonahX followed your suggested direction, let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log o