liurenjie1024 merged PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Fokko commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1549860927
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
self.co
liurenjie1024 commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1547526634
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
Fokko commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1547503192
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
self.co
liurenjie1024 commented on PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#issuecomment-2031513654
> Hi, @Fokko Thanks for this fix. It also reminds me that should we append
the warehouse parameter to `getConfig` call?
Seems we already have that.
--
This is an automa
liurenjie1024 commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1542207188
##
crates/catalog/rest/src/catalog.rs:
##
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
-let file_io = match
