Fokko commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1547503192


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -617,7 +617,13 @@ impl RestCatalog {
             props.extend(config);
         }
 
-        let file_io = match 
self.config.warehouse.as_deref().or(metadata_location) {
+        let warehouse_path = match self.config.warehouse.as_deref() {
+            Some(url) if url.contains("://") => Some(url),

Review Comment:
   This is also happening [below in the 
`FileIO::from_path`](https://github.com/apache/iceberg-rust/blob/d57d91b9a72c516c6665d5faef349f52ebe59585/crates/iceberg/src/io.rs#L155),
 but it raises an exception we want to avoid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to