liurenjie1024 commented on code in PR #308:
URL: https://github.com/apache/iceberg-rust/pull/308#discussion_r1542207188
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -617,7 +617,13 @@ impl RestCatalog {
props.extend(config);
}
- let file_io = match
self.config.warehouse.as_deref().or(metadata_location) {
+ let warehouse_path = match self.config.warehouse.as_deref() {
+ Some(url) if url.contains("://") => Some(url),
Review Comment:
How about replacing it with
[Url::parse](https://docs.rs/url/latest/url/struct.Url.html#method.parse)? It
seems more robust to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
