Re: [PR] Spark: Test deletes with format-version=3 [iceberg]

2024-11-13 Thread via GitHub
nastra commented on code in PR #11538: URL: https://github.com/apache/iceberg/pull/11538#discussion_r1841683046 ## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java: ## @@ -99,16 +100,21 @@ public class TestSparkReaderDeletes extends Del

Re: [PR] Spark: Test deletes with format-version=3 [iceberg]

2024-11-13 Thread via GitHub
nastra commented on code in PR #11538: URL: https://github.com/apache/iceberg/pull/11538#discussion_r1841682548 ## mr/src/test/java/org/apache/iceberg/mr/TestInputFormatReaderDeletes.java: ## @@ -49,18 +49,18 @@ public class TestInputFormatReaderDeletes extends DeleteReadTests

Re: [PR] Spark: Test deletes with format-version=3 [iceberg]

2024-11-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #11538: URL: https://github.com/apache/iceberg/pull/11538#discussion_r1840930383 ## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java: ## @@ -99,16 +100,21 @@ public class TestSparkReaderDeletes ex