amogh-jahagirdar commented on code in PR #11538:
URL: https://github.com/apache/iceberg/pull/11538#discussion_r1840930383
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -99,16 +100,21 @@ public class TestSparkReaderDeletes extends
DeleteReadTests {
protected static SparkSession spark = null;
protected static HiveCatalog catalog = null;
- @Parameter(index = 1)
+ @Parameter(index = 2)
private boolean vectorized;
- @Parameters(name = "format = {0}, vectorized = {1}")
+ @Parameter(index = 3)
+ private PlanningMode planningMode;
+
+ @Parameters(name = "format = {0}, formatVersion = {1}, vectorized = {2},
planningMode = {3}")
Review Comment:
Should we call the first argument fileFormat instead?
##########
mr/src/test/java/org/apache/iceberg/mr/TestInputFormatReaderDeletes.java:
##########
@@ -49,18 +49,18 @@ public class TestInputFormatReaderDeletes extends
DeleteReadTests {
private final HadoopTables tables = new HadoopTables(conf);
private TestHelper helper;
- @Parameter(index = 1)
+ @Parameter(index = 2)
private String inputFormat;
- @Parameters(name = "fileFormat = {0}, inputFormat = {1}")
+ @Parameters(name = "fileFormat = {0}, formatVersion = {1}, inputFormat =
{2}")
public static Object[][] parameters() {
return new Object[][] {
- {FileFormat.PARQUET, "IcebergInputFormat"},
- {FileFormat.AVRO, "IcebergInputFormat"},
- {FileFormat.ORC, "IcebergInputFormat"},
- {FileFormat.PARQUET, "MapredIcebergInputFormat"},
- {FileFormat.AVRO, "MapredIcebergInputFormat"},
- {FileFormat.ORC, "MapredIcebergInputFormat"},
+ {FileFormat.PARQUET, 2, "IcebergInputFormat"},
+ {FileFormat.AVRO, 2, "IcebergInputFormat"},
+ {FileFormat.ORC, 2, "IcebergInputFormat"},
+ {FileFormat.PARQUET, 2, "MapredIcebergInputFormat"},
+ {FileFormat.AVRO, 2, "MapredIcebergInputFormat"},
+ {FileFormat.ORC, 2, "MapredIcebergInputFormat"},
Review Comment:
Should some of these be testing V3 instead? Or depending on how long these
take at the moment, we could add some more for testing 3
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -82,12 +83,15 @@ public abstract class DeleteReadTests {
@Parameter protected FileFormat format;
+ @Parameter(index = 1)
+ protected int formatVersion;
+
@Parameters(name = "fileFormat = {0}")
public static Object[][] parameters() {
return new Object[][] {
- new Object[] {FileFormat.PARQUET},
- new Object[] {FileFormat.AVRO},
- new Object[] {FileFormat.ORC}
+ new Object[] {FileFormat.PARQUET, 2},
+ new Object[] {FileFormat.AVRO, 2},
+ new Object[] {FileFormat.ORC, 2}
Review Comment:
Same as below, any reason we shouldn't just add some V3 cases here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
