nastra commented on code in PR #11538:
URL: https://github.com/apache/iceberg/pull/11538#discussion_r1841682548
##########
mr/src/test/java/org/apache/iceberg/mr/TestInputFormatReaderDeletes.java:
##########
@@ -49,18 +49,18 @@ public class TestInputFormatReaderDeletes extends
DeleteReadTests {
private final HadoopTables tables = new HadoopTables(conf);
private TestHelper helper;
- @Parameter(index = 1)
+ @Parameter(index = 2)
private String inputFormat;
- @Parameters(name = "fileFormat = {0}, inputFormat = {1}")
+ @Parameters(name = "fileFormat = {0}, formatVersion = {1}, inputFormat =
{2}")
public static Object[][] parameters() {
return new Object[][] {
- {FileFormat.PARQUET, "IcebergInputFormat"},
- {FileFormat.AVRO, "IcebergInputFormat"},
- {FileFormat.ORC, "IcebergInputFormat"},
- {FileFormat.PARQUET, "MapredIcebergInputFormat"},
- {FileFormat.AVRO, "MapredIcebergInputFormat"},
- {FileFormat.ORC, "MapredIcebergInputFormat"},
+ {FileFormat.PARQUET, 2, "IcebergInputFormat"},
+ {FileFormat.AVRO, 2, "IcebergInputFormat"},
+ {FileFormat.ORC, 2, "IcebergInputFormat"},
+ {FileFormat.PARQUET, 2, "MapredIcebergInputFormat"},
+ {FileFormat.AVRO, 2, "MapredIcebergInputFormat"},
+ {FileFormat.ORC, 2, "MapredIcebergInputFormat"},
Review Comment:
yeah that probably makes sense to test these with V3 now too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
