amogh-jahagirdar merged PR #8854:
URL: https://github.com/apache/iceberg/pull/8854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
amogh-jahagirdar commented on PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#issuecomment-1824793066
Thanks for the reviews @nastra @rakesh-das08 @ajantha-bhat @aokolnychyi !
I'm going to merge this to keep the fix focused on the procedure output for
non-main branches. There are
nastra commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1403186632
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,12 +79,13 @@ public InternalRow[] call(InternalRow args)
nastra commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1403184858
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -18,6 +18,8 @@
*/
package org.apache.iceberg.spark.proced
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1403040251
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1403010409
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1402640731
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
aokolnychyi commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1382322425
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow ar
aokolnychyi commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1382322125
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow ar
nastra commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1363667603
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow args) {
amogh-jahagirdar closed pull request #8854: Spark: Fix Fast forward procedure
output for non-main branches
URL: https://github.com/apache/iceberg/pull/8854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ajantha-bhat commented on PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#issuecomment-1766410898
logged the flaky test: #8855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rakesh-das08 commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362071081
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow a
ajantha-bhat commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362069529
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow a
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362063516
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
ajantha-bhat commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362051079
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow a
ajantha-bhat commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362035790
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestFastForwardBranchProcedure.java:
##
@@ -188,4 +188,38 @@ public void testInval
rakesh-das08 commented on PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#issuecomment-1766321748
@amogh-jahagirdar the fix LGTM. Thanks for fixing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
18 matches
Mail list logo
