amogh-jahagirdar commented on PR #8854: URL: https://github.com/apache/iceberg/pull/8854#issuecomment-1824793066
Thanks for the reviews @nastra @rakesh-das08 @ajantha-bhat @aokolnychyi ! I'm going to merge this to keep the fix focused on the procedure output for non-main branches. There are still 2 pending related items: 1.) Fixing the naming in the replace/fastForward APIs: That PR is here https://github.com/apache/iceberg/pull/9134/files 2.) The original issue for fast forwarding a branch which does not exist yet (this PR still preserves the original behavior, just with an explicit null check beforehand).https://github.com/apache/iceberg/issues/8849 For 2, I do agree it's an awkward experience that should be fixed (after all many folks would write to audit first before the existence of main). I noticed that recently there was a `create` added which does add the dummy append. We could maybe stitch together the APIs to achieve the "create" if it does not already exist or we could add a new API. The first is preferable IMO but I'd need to check further on the feasibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
