nastra commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1363667603
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##########
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow args) {
return modifyIcebergTable(
tableIdent,
table -> {
- long currentRef = table.currentSnapshot().snapshotId();
+ long currentRef = table.snapshot(source).snapshotId();
Review Comment:
wouldn't we fail here if that particular branch doesn't exist? Because the
branch existence checks only happen one step later in
`table.manageSnapshots().fastForwardBranch`. I think we should also add a test
where that procedure is called with a non-existing branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
