Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1377994540 ## spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -337,7 +337,7 @@ private void replaceManifests( ad

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi merged PR #8928: URL: https://github.com/apache/iceberg/pull/8928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1377066516 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -82,10 +83,12 @@ public class BaseRewriteManifests extends SnapshotProducer this.man

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1373976469 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -160,11 +163,10 @@ public RewriteManifests addManifest(ManifestFile manifest) { }

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

flyrain commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1376706853 ## spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -337,7 +337,7 @@ private void replaceManifests( addedM

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1374826073 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -443,6 +444,14 @@ public void testBasicManifestReplacement() throws IOException { Li

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

singhpk234 commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1374737812 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -443,6 +444,14 @@ public void testBasicManifestReplacement() throws IOException { Lis

Re: [PR] Spark: Avoid extra copies of manifests while optimizing V2 tables [iceberg]

aokolnychyi commented on code in PR #8928: URL: https://github.com/apache/iceberg/pull/8928#discussion_r1373976469 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -160,11 +163,10 @@ public RewriteManifests addManifest(ManifestFile manifest) { }