singhpk234 commented on code in PR #8928:
URL: https://github.com/apache/iceberg/pull/8928#discussion_r1374737812
##########
core/src/test/java/org/apache/iceberg/TestRewriteManifests.java:
##########
@@ -443,6 +444,14 @@ public void testBasicManifestReplacement() throws
IOException {
List<ManifestFile> manifests = snapshot.allManifests(table.io());
Assert.assertEquals(3, manifests.size());
+ if (formatVersion == 1) {
+
assertThat(manifests.get(0).path()).isNotEqualTo(firstNewManifest.path());
+
assertThat(manifests.get(1).path()).isNotEqualTo(secondNewManifest.path());
+ } else {
+ assertThat(manifests.get(0).path()).isEqualTo(firstNewManifest.path());
+ assertThat(manifests.get(1).path()).isEqualTo(secondNewManifest.path());
+ }
Review Comment:
[minor] A comment might be helpful
shouldn't we check if it's format = 1 and snapshotIdInheritence enabled ?
##########
core/src/test/java/org/apache/iceberg/TestRewriteManifests.java:
##########
@@ -443,6 +444,14 @@ public void testBasicManifestReplacement() throws
IOException {
List<ManifestFile> manifests = snapshot.allManifests(table.io());
Assert.assertEquals(3, manifests.size());
+ if (formatVersion == 1) {
+
assertThat(manifests.get(0).path()).isNotEqualTo(firstNewManifest.path());
+
assertThat(manifests.get(1).path()).isNotEqualTo(secondNewManifest.path());
+ } else {
+ assertThat(manifests.get(0).path()).isEqualTo(firstNewManifest.path());
+ assertThat(manifests.get(1).path()).isEqualTo(secondNewManifest.path());
+ }
Review Comment:
[minor] shouldn't we check if it's format = 1 and snapshotIdInheritence
enabled ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
