aokolnychyi commented on code in PR #8928:
URL: https://github.com/apache/iceberg/pull/8928#discussion_r1377066516
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -82,10 +83,12 @@ public class BaseRewriteManifests extends
SnapshotProducer<RewriteManifests>
this.manifestTargetSizeBytes =
ops.current()
.propertyAsLong(MANIFEST_TARGET_SIZE_BYTES,
MANIFEST_TARGET_SIZE_BYTES_DEFAULT);
- this.snapshotIdInheritanceEnabled =
+ this.formatVersion = ops.current().formatVersion();
+ boolean snapshotIdInheritanceEnabled =
ops.current()
.propertyAsBoolean(
SNAPSHOT_ID_INHERITANCE_ENABLED,
SNAPSHOT_ID_INHERITANCE_ENABLED_DEFAULT);
+ this.canInheritSnapshotId = formatVersion > 1 ||
snapshotIdInheritanceEnabled;
Review Comment:
Updated the doc in this PR, that's a good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
