Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-12-03 Thread via GitHub
danielcweeks merged PR #11388: URL: https://github.com/apache/iceberg/pull/11388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-12-03 Thread via GitHub
nastra commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1868056254 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java: ## @@ -397,4 +412,155 @@ public UnboundFunction loadFunction(Identifier ident) th

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-12-03 Thread via GitHub
danielcweeks commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1868017844 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java: ## @@ -397,4 +412,155 @@ public UnboundFunction loadFunction(Identifier iden

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-11-21 Thread via GitHub
nastra commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1853401637 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseCatalog.java: ## @@ -35,7 +35,9 @@ abstract class BaseCatalog ProcedureCatalog, Suppor

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-11-04 Thread via GitHub
nastra commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1827316828 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -76,15 +76,21 @@ static Map environmentCatalogConfig() { HashMap::new))

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-11-04 Thread via GitHub
nastra commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1827316470 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -37,12 +38,19 @@ public class RESTCatalogServer { private static final Logg

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-31 Thread via GitHub
danielcweeks commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1825020356 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -37,12 +38,19 @@ public class RESTCatalogServer { private static fina

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-31 Thread via GitHub
danielcweeks commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1825021901 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseCatalog.java: ## @@ -35,7 +35,9 @@ abstract class BaseCatalog ProcedureCatalog,

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-31 Thread via GitHub
danielcweeks commented on code in PR #11388: URL: https://github.com/apache/iceberg/pull/11388#discussion_r1824960092 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -76,15 +76,21 @@ static Map environmentCatalogConfig() { HashMap:

[PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-24 Thread via GitHub
nastra opened a new pull request, #11388: URL: https://github.com/apache/iceberg/pull/11388 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-24 Thread via GitHub
nastra commented on PR #10231: URL: https://github.com/apache/iceberg/pull/10231#issuecomment-2434817079 Closing this in favor of https://github.com/apache/iceberg/pull/11388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-24 Thread via GitHub
nastra closed pull request #10231: Spark: Add view support to SparkSessionCatalog URL: https://github.com/apache/iceberg/pull/10231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-14 Thread via GitHub
nastra commented on PR #10231: URL: https://github.com/apache/iceberg/pull/10231#issuecomment-2411168037 > @nastra Do we want to move forward with this PR? eventually yes, but there have been some open items that I haven't had time to work on yet -- This is an automated message fro

Re: [PR] Spark: Add view support to SparkSessionCatalog [iceberg]

2024-10-11 Thread via GitHub
manuzhang commented on PR #10231: URL: https://github.com/apache/iceberg/pull/10231#issuecomment-2408331380 @nastra Do we want to move forward with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above