danielcweeks commented on code in PR #11388:
URL: https://github.com/apache/iceberg/pull/11388#discussion_r1825020356
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -37,12 +38,19 @@
public class RESTCatalogServer {
private static final Logger LOG =
LoggerFactory.getLogger(RESTCatalogServer.class);
- static final String REST_PORT = "rest.port";
+ public static final String REST_PORT = "rest.port";
static final int REST_PORT_DEFAULT = 8181;
private Server httpServer;
+ private final Map<String, String> config;
- RESTCatalogServer() {}
+ public RESTCatalogServer() {
Review Comment:
Same here, I'd like to keep this package protected and leverage the
ExtensionContext address the setup/config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
