Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-31 Thread via GitHub
nastra merged PR #9513: URL: https://github.com/apache/iceberg/pull/9513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on PR #9513: URL: https://github.com/apache/iceberg/pull/9513#issuecomment-1917565679 I pointed out a few things that I think I would change, but there is nothing blocking this. +1 overall. Please fix what you agree with (including the `SHOW VIEWS` behavior with temp views)

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471683079 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec.scala: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471678490 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,6 +1149,159 @@ public void createViewWithSubqueryExpression

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471677391 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,6 +1149,159 @@ public void createViewWithSubqueryExpression

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471676989 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,6 +1149,159 @@ public void createViewWithSubqueryExpression

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471676481 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,6 +1149,159 @@ public void createViewWithSubqueryExpression

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471671329 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeV2ViewExec.scala: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471669400 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,6 +1149,159 @@ public void createViewWithSubqueryExpression

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471666384 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +128,18 @@ case class Extend

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471663971 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +128,18 @@ case class Extend

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471663971 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +128,18 @@ case class Extend

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-30 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471656403 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -60,6 +63,13 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-29 Thread via GitHub
nastra commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1469484505 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec.scala: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-29 Thread via GitHub
nastra commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1469477447 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -60,17 +65,27 @@ case class RewriteViewCommands(spa

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-29 Thread via GitHub
nastra commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1469444718 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +132,47 @@ case class Extend

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-28 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1468941095 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -60,17 +65,27 @@ case class RewriteViewCommands(spa

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-28 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1468939586 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec.scala: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-28 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1468939586 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec.scala: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

Re: [PR] Spark: Add support for describing/showing views [iceberg]

2024-01-28 Thread via GitHub
rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1468939456 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +132,47 @@ case class Extend

[PR] Spark: Add support for describing/showing views [iceberg]

2024-01-18 Thread via GitHub
nastra opened a new pull request, #9513: URL: https://github.com/apache/iceberg/pull/9513 This adds support for: * `DESCRIBE ` / `DESCRIBE EXTENDED ` * `SHOW VIEWS` / `SHOW VIEWS LIKE ` * `SHOW TBLPROPERTIES ` * `SHOW CREATE TABLE ` -- This is an automated message from the Apac