rdblue commented on code in PR #9513: URL: https://github.com/apache/iceberg/pull/9513#discussion_r1468939456
########## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ########## @@ -123,6 +132,47 @@ case class ExtendedDataSourceV2Strategy(spark: SparkSession) extends Strategy wi allowExisting = allowExisting, replace = replace) :: Nil + case AlterViewAs(ResolvedV2View(catalog, ident, _), queryText, query) => + CreateV2ViewExec( + catalog = catalog, + ident = ident, + queryText = queryText, + columnAliases = Seq.empty, + columnComments = Seq.empty, + queryColumnNames = query.schema.fieldNames, + viewSchema = query.schema, + comment = None, + properties = Map.empty, + allowExisting = false, + replace = true) :: Nil + + case SetViewProperties(ResolvedV2View(catalog, ident, _), properties) => + val changes = properties.map { + case (property, value) => ViewChange.setProperty(property, value) + }.toSeq + AlterV2ViewExec(catalog, ident, changes) :: Nil + + case UnsetViewProperties(ResolvedV2View(catalog, ident, view), propertyKeys, ifExists) => Review Comment: Can you remove the unrelated changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org