rdblue commented on code in PR #9513:
URL: https://github.com/apache/iceberg/pull/9513#discussion_r1471663971
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala:
##########
@@ -123,6 +128,18 @@ case class ExtendedDataSourceV2Strategy(spark:
SparkSession) extends Strategy wi
allowExisting = allowExisting,
replace = replace) :: Nil
+ case d@DescribeRelation(ResolvedV2View(catalog, ident), _, isExtended, _)
=>
Review Comment:
I understand not wanting to bother with `output`, but I think the best
practice is to preserve `output` from the logical plan to the physical plan.
That's because resolution has occurred with the IDs from the logical plan and
we don't want to reassign internal IDs in the physical plan. They should always
match. That's why most Spark plans (like `DescribeTableExec`) copy and reuse
the output attrs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
