Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko merged PR #8919: URL: https://github.com/apache/iceberg/pull/8919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on PR #8919: URL: https://github.com/apache/iceberg/pull/8919#issuecomment-1883219914 This looks great, and I don't see any open comments. If there is anything we can follow up on in a separate PR. I'll go ahead and rebase and merge this 🚀 Thanks for the reviews @rdblue, @R

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on PR #8919: URL: https://github.com/apache/iceberg/pull/8919#issuecomment-1879255453 @Fokko I updated after your comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1443361277 ## site/docs/community.md: ## @@ -40,13 +40,13 @@ Issues are tracked in GitHub: ## Slack -We use the [Apache Iceberg workspace](https://apache-iceberg.slack.

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1443359408 ## site/nav.yml: ## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1443356487 ## site/docs/community.md: ## @@ -40,13 +40,13 @@ Issues are tracked in GitHub: ## Slack -We use the [Apache Iceberg workspace](https://apache-iceberg.slack.

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1443340509 ## site/docs/community.md: ## @@ -40,13 +40,13 @@ Issues are tracked in GitHub: ## Slack -We use the [Apache Iceberg workspace](https://apache-iceberg.slack.com/) on

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391628443 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- co

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391601671 ## site/dev/common.sh: ## @@ -0,0 +1,124 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391589914 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391563201 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391561630 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1389541886 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In the

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1389531071 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1389531071 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1388598336 ## .github/workflows/site-ci.yml: ## @@ -0,0 +1,40 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1388593968 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- content.tab

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1388588215 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In the Iceberg

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on PR #8919: URL: https://github.com/apache/iceberg/pull/8919#issuecomment-1804689906 Niiice! Got the `make serve` running in one go now: https://github.com/apache/iceberg/assets/1134248/4d8dd416-48d2-4281-b9e6-f060d6eb8dbd";> -- This is an automated message from

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386524118 ## site/dev/common.sh: ## @@ -0,0 +1,122 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386414038 ## site/dev/common.sh: ## @@ -0,0 +1,125 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license a

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386219088 ## site/dev/common.sh: ## @@ -0,0 +1,125 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386213158 ## site/README.md: ## @@ -83,59 +99,27 @@ All previously versioned docs will be committed in `docs-` branches and       └── ... ``` -### Install - -1. (Opt

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386210561 ## site/Makefile: ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386208436 ## site/dev/common.sh: ## @@ -0,0 +1,125 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license a

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386194229 ## site/.gitignore: ## @@ -1,13 +1,3 @@ -## Temp remove for first phase Review Comment: Yeah, fair enough...I added a few specifics from my previous one --

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

Fokko commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386152391 ## site/dev/common.sh: ## @@ -0,0 +1,125 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1386108273 ## site/docs/docs/nightly/docs/configuration.md: ## Review Comment: All of the changes under `site/docs/docs/**` are all in a seperate commit. This was just