Fokko commented on code in PR #8919:
URL: https://github.com/apache/iceberg/pull/8919#discussion_r1388593968
##########
site/mkdocs.yml:
##########
@@ -23,33 +23,37 @@ theme:
logo: assets/images/iceberg-logo-icon.png
favicon: assets/images/favicon-96x96.png
features:
+ - content.tabs.link
+ - content.code.copy
+ - content.code.annotate
- navigation.tabs
- navigation.path
- navigation.top
- navigation.tracking
- - toc.follow
+ - offline
- search.suggest
- search.highlight
- - content.tabs.link
- - content.code.copy
- - content.code.annotate
+ - toc.follow
plugins:
- search
- macros:
include_yaml:
- variables.yml
- monorepo
+ - offline:
+ enabled: !ENV [OFFLINE, false]
nav:
- Quickstart:
- Spark: spark-quickstart.md
- Hive: hive-quickstart.md
- Docs:
- nightly: '!include docs/docs/nightly/mkdocs.yml'
-# - latest: '!include docs/docs/latest/mkdocs.yml'
-# - 1.3.1: '!include docs/docs/1.3.1/mkdocs.yml'
-# - 1.3.0: '!include docs/docs/1.3.0/mkdocs.yml'
+ - latest: '!include docs/docs/latest/mkdocs.yml'
Review Comment:
I was looking at this:
<img width="1524" alt="image"
src="https://github.com/apache/iceberg/assets/1134248/c15926b7-9d7c-4017-9ece-819bea66c930";>
It looks a bit odd since 1.4.2 is the same as latest. Do we really need
this, it is quite obvious that 1.4.2 is the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
