Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2150600734 Thanks, everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

szehon-ho commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2150596338 Thanks @huaxingao for the pr, @nastra @viirya for reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

szehon-ho merged PR #10442: URL: https://github.com/apache/iceberg/pull/10442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1628012768 ## gradle.properties: ## @@ -20,7 +20,7 @@ systemProp.defaultFlinkVersions=1.19 systemProp.knownFlinkVersions=1.17,1.18,1.19 systemProp.defaultHiveVersions=2 sys

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627998403 ## gradle.properties: ## @@ -20,7 +20,7 @@ systemProp.defaultFlinkVersions=1.19 systemProp.knownFlinkVersions=1.17,1.18,1.19 systemProp.defaultHiveVersions=2 system

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627997817 ## gradle.properties: ## @@ -20,7 +20,7 @@ systemProp.defaultFlinkVersions=1.19 systemProp.knownFlinkVersions=1.17,1.18,1.19 systemProp.defaultHiveVersions=2 system

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2150333597 > could you also please add the below diff to TestViews.showViews() Added. Thanks for the suggestion! @nastra -- This is an automated message from the Apache Git Service. To

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2150287932 @huaxingao could you also please add the below diff to `TestViews.showViews()` ``` --- a/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.jav

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627947147 ## spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -165,6 +167,14 @@ public void testCreateTable() { Assert.assert

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627163873 ## spark/v3.5/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -174,6 +176,14 @@ public void testCreateTable() { .hasSize(3);

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627163414 ## spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -165,6 +167,14 @@ public void testCreateTable() { Assert.assertEqu

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

nastra commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2148744879 I'll take a look later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

szehon-ho commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2148582710 Ill commit this tomorrow if no further comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

viirya commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626612224 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommands(s

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

szehon-ho commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2148340152 @nastra fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

viirya commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626517298 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommands(s

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

viirya commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626512474 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommands(s

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

viirya commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626506489 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommands(s

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626362527 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommand

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

szehon-ho commented on code in PR #10442: URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626346354 ## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -66,10 +66,13 @@ case class RewriteViewCommand

Re: [PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao commented on PR #10442: URL: https://github.com/apache/iceberg/pull/10442#issuecomment-2147946347 cc @nastra @szehon-ho @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] SHOW VIEWS failed with AssertionError [iceberg]

huaxingao opened a new pull request, #10442: URL: https://github.com/apache/iceberg/pull/10442 ``` sql("CREATE VIEW %s AS SELECT 1 AS id", "test"); sql("SHOW VIEWS") assertion failed java.lang.AssertionError: assertion failed at scala.Predef$.assert(Predef.scala:208)