huaxingao commented on code in PR #10442:
URL: https://github.com/apache/iceberg/pull/10442#discussion_r1626362527
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -66,10 +66,13 @@ case class RewriteViewCommands(spark: SparkSession) extends
Rule[LogicalPlan] wi
allowExisting = allowExisting,
replace = replace)
- case ShowViews(UnresolvedNamespace(Seq()), pattern, output)
- if ViewUtil.isViewCatalog(catalogManager.currentCatalog) =>
- ShowIcebergViews(ResolvedNamespace(catalogManager.currentCatalog,
catalogManager.currentNamespace),
- pattern, output)
+ case ShowViews(UnresolvedNamespace(Seq()), pattern, output) =>
Review Comment:
The case below seems OK. If `ViewUtil.isViewCatalog(catalog)` is not
satisfied, it will just skip this case.
For `case ShowViews(UnresolvedNamespace(Seq()), pattern, output)`, if
`ViewUtil.isViewCatalog(catalog)` is not satisfied, it goes to the case below
`case ShowViews(UnresolvedNamespace(CatalogAndNamespace(catalog, ns)), pattern,
output)`, it failed in `CatalogAndNamespace(catalog, ns)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
