nastra commented on code in PR #10442:
URL: https://github.com/apache/iceberg/pull/10442#discussion_r1627163414


##########
spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java:
##########
@@ -165,6 +167,14 @@ public void testCreateTable() {
     Assert.assertEquals("Should be partitioned on 3 columns", 3, 
third.spec().fields().size());
   }
 
+  @Test
+  public void showView() {
+    sql("DROP VIEW IF EXISTS %s", "test");
+    sql("CREATE VIEW %s AS SELECT 1 AS id", "test");
+    Object[] expected = row("default", "test", false);
+    assertThat(sql("SHOW VIEWS")).contains(expected);

Review Comment:
   `expected` can be inlined here:
   ```suggestion
       assertThat(sql("SHOW VIEWS")).contains(row("default", "test", false));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to