JE-Chen closed pull request #1206: PR #1169
URL: https://github.com/apache/iceberg-python/pull/1206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1777321794
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1777551420
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1777324689
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1777321794
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1776310431
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1776310431
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1776310431
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1776008439
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623776
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775734036
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775672026
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775672026
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775666368
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775666368
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623041
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623776
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623041
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623776
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775613883
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775612249
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775500020
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775491517
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775490550
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
e
kevinjqliu commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775434612
##
pyiceberg/io/pyarrow.py:
##
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
JE-Chen opened a new pull request, #1206:
URL: https://github.com/apache/iceberg-python/pull/1206
Did you mean to change it like this PR? @kevinjqliu
I think we need to edit the test as well.
Becasue test no longer raise ns TypeError.
--
This is an automated message from the Apache
26 matches
Mail list logo
