JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1775623041
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
elif pa.types.is_date32(primitive):
return DateType()
- elif isinstance(primitive, pa.Time64Type) and primitive.unit == "us":
+ elif isinstance(primitive, pa.Time64Type) and primitive.unit in ["us",
"ns"]:
Review Comment:
```
elif primitive.unit == "ns":
if self._downcast_ns_timestamp_to_us:
primitive = cast(pa.TimestampType, "us")
return TimeType(primitive)
```
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
elif pa.types.is_date32(primitive):
return DateType()
- elif isinstance(primitive, pa.Time64Type) and primitive.unit == "us":
+ elif isinstance(primitive, pa.Time64Type) and primitive.unit in ["us",
"ns"]:
Review Comment:
You mean return new TimeType using new primitive right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
