JE-Chen commented on code in PR #1206:
URL: https://github.com/apache/iceberg-python/pull/1206#discussion_r1776310431
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1068,20 +1068,13 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return StringType()
elif pa.types.is_date32(primitive):
return DateType()
- elif isinstance(primitive, pa.Time64Type) and primitive.unit == "us":
+ elif isinstance(primitive, pa.Time64Type) and primitive.unit in ["us",
"ns"]:
Review Comment:
I am confused.
Did you mean that I need a new class variable _downcast_ns_time64type_to_us
and a new condition to check?
```
if self._downcast_ns_time64type_to_us:
# what should be done here?
```
Or should I add some code under the original condition:
```
if self._downcast_ns_timestamp_to_us:
# Add something here.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
