marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006672626
> > yes you're correct - but I think the difference is when we checked
`properties.is_emtpy()` and returned `None` the serialization (due to serde
config) was completely skipped
liurenjie1024 commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006638318
> yes you're correct - but I think the difference is when we checked
`properties.is_emtpy()` and returned `None` the serialization (due to serde
config) was completely skipped. A
marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006453883
yes you're correct - but I think the difference is when we checked
`properties.is_emtpy()` and returned `None` the serialization (due to serde
config) was completely skipped. As
liurenjie1024 commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006184189
> Doesn't the test assume that e.g. the key properties is present in the
serialized JSON?
IIUC, The test reads [this
file](https://github.com/apache/iceberg/blob/3d929d459
marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006089207
> > @liurenjie1024 Thanks for the review, I applied those changes /
suggestions.
> > I was testing / using Trino as a client.
>
> Interesting, trino is supposed to use
liurenjie1024 merged PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006052205
> @liurenjie1024 Thanks for the review, I applied those changes /
suggestions.
>
> I was testing / using Trino as a client.
Interesting, trino is supposed to use jav
marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2005809328
@liurenjie1024
Thanks for the review, I will apply those changes / suggestions.
I was testing / using Trino as a client.
--
This is an automated message from the Apa
liurenjie1024 commented on code in PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#discussion_r1529576423
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -297,19 +298,37 @@ impl TableMetadataBuilder {
properties,
} = table_creation;
-
ZENOTME commented on code in PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#discussion_r1528887679
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -727,14 +746,10 @@ pub(super) mod _serde {
.collect(),
default_spec_id: v.d
ZENOTME commented on code in PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#discussion_r1528887679
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -727,14 +746,10 @@ pub(super) mod _serde {
.collect(),
default_spec_id: v.d
marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2002565662
cc @liurenjie1024 @Xuanwo @ZENOTME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
marvinlanhenke opened a new pull request, #272:
URL: https://github.com/apache/iceberg-rust/pull/272
### Which issue does this PR close?
Closes #271
### Rationale for this change
Serialization of metadata.json has missing fields (properties and snapshots)
when being empty this
13 matches
Mail list logo
