marvinlanhenke commented on PR #272: URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006089207
> > @liurenjie1024 Thanks for the review, I applied those changes / suggestions. > > I was testing / using Trino as a client. > > Interesting, trino is supposed to use java library, but [this test](https://github.com/apache/iceberg/blob/489ec2972e352a701745f0a15bdfaa722ad07f3a/core/src/test/java/org/apache/iceberg/TestTableMetadata.java#L1360) says it's valid. Anyway, let's move on and test it later. > > cc @Fokko Any ideas? Doesn't the test assume that e.g. the key `properties` is present in the serialized JSON? During my tests I got the error-message that Trino could not parse missing properties, thus the PR. Thanks again for merging and the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
