marvinlanhenke commented on PR #272:
URL: https://github.com/apache/iceberg-rust/pull/272#issuecomment-2006672626

   > > yes you're correct - but I think the difference is when we checked 
`properties.is_emtpy()` and returned `None` the serialization (due to serde 
config) was completely skipped. As far as I understand the java implementation 
when the json is missing e.g. `properties` an empty map is created? 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L441-L447
   > 
   > Yes, that means when `properties` is missed, it should not report error. 
What kind of error did you see?
   
   Now, I get your point - the error I was getting "...Could not parse missing 
`properties" by the trino-client


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to