Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
kevinjqliu commented on PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#issuecomment-2855483829 Thanks @petern48 for the contribution and @Fokko for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
kevinjqliu merged PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
kevinjqliu commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2075684333 ## .github/workflows/python-ci.yml: ## @@ -65,4 +65,24 @@ jobs: - name: Linters run: make lint - name: Tests - run: make test-coverage +

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
petern48 commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2075659286 ## .github/workflows/python-ci.yml: ## @@ -65,4 +65,24 @@ jobs: - name: Linters run: make lint - name: Tests - run: make test-coverage +

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
Fokko commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2075001887 ## .github/workflows/python-ci.yml: ## @@ -65,4 +65,24 @@ jobs: - name: Linters run: make lint - name: Tests - run: make test-coverage +

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-06 Thread via GitHub
Fokko commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r207593 ## .github/workflows/python-ci.yml: ## @@ -65,4 +65,24 @@ jobs: - name: Linters run: make lint - name: Tests - run: make test-coverage Revie

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-05 Thread via GitHub
petern48 commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2074471301 ## .github/workflows/python-ci.yml: ## @@ -66,3 +66,20 @@ jobs: run: make lint - name: Tests run: make test-coverage + + integration-test: +

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2072495090 ## .github/workflows/python-ci.yml: ## @@ -66,3 +66,20 @@ jobs: run: make lint - name: Tests run: make test-coverage + + integration-test:

[PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-03 Thread via GitHub
petern48 opened a new pull request, #1963: URL: https://github.com/apache/iceberg-python/pull/1963 Closes #1942 # Rationale for this change This condenses similar CI logic into one place # Are these changes tested? # Are there any user-facing changes?