petern48 commented on code in PR #1963:
URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2074471301
##########
.github/workflows/python-ci.yml:
##########
@@ -66,3 +66,20 @@ jobs:
run: make lint
- name: Tests
run: make test-coverage
+
+ integration-test:
+ runs-on: ubuntu-22.04
+
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 2
+ - name: Install system dependencies
+ run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for
kerberos
+ - name: Install
+ run: make install
+ - name: Run integration tests
+ run: make test-integration
Review Comment:
Ah, nice catch. Personally, I like the idea of having them stay separate, so
they can run in parallel. I pushed a change separating them while still running
the full Python version matrix for both unit and integration tests with
coverage. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
