Fokko merged PR #218:
URL: https://github.com/apache/iceberg-python/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1862970532
Thanks for adding this @jqin61 and @HonahX for the quick review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jqin61 commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1862964912
Hi @Fokko ! It looks like I do not have permission to squash and merge the
pull request. Could you merge it for me, thank you so much!
--
This is an automated message from the Apach
Fokko commented on code in PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#discussion_r1430698574
##
mkdocs/docs/configuration.md:
##
@@ -74,6 +74,7 @@ For the FileIO there are several configuration options
available:
| s3.signer| bearer
Fokko commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1861769143
@jqin61 Thanks for verifying! That's awesome; the less warnings the better 👍
I agree with the comment by @HonahX and @syun64 that we should add the property
to the docs; we want to mak
syun64 commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1861760723
Should we add this to the mkdocs?
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md?plain=1#L76
This will add the config property to PyIceberg Conf
jqin61 commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1861759030
Sorry for the confusion of changing my GitHub account and the inconvenience
I brought in approving workflows.
--
This is an automated message from the Apache Git Service.
To respon
jqin61 commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1861741283
> This looks good @jqin61 Thanks for adding this.
>
> One minor thing I noticed is that s3fs is looking for an int, while
pyarrow expects a double. Can you check
Fokko commented on code in PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#discussion_r1429804685
##
pyiceberg/io/pyarrow.py:
##
@@ -330,6 +331,9 @@ def _initialize_fs(self, scheme: str, netloc: Optional[str]
= None) -> FileSyste
if proxy_uri := sel
Fokko commented on code in PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#discussion_r1429803361
##
pyiceberg/io/fsspec.py:
##
@@ -127,6 +128,9 @@ def _s3(properties: Properties) -> AbstractFileSystem:
if proxy_uri := properties.get(S3_PROXY_URI):
HonahX commented on PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1858723785
Thanks @jqin61. This looks great! Shall we update the doc as well?
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md?plain=1#L67-L76
so that people
jqin61 opened a new pull request, #218:
URL: https://github.com/apache/iceberg-python/pull/218
Hi! We noticed we are running into exceptions thrown due to aws timeout when
we are using pyiceberg.io.pyarrow.PyArrowFileIO:
```
OSError: When reading information for key
'table/metadata/b7
12 matches
Mail list logo
