Fokko commented on code in PR #218:
URL: https://github.com/apache/iceberg-python/pull/218#discussion_r1430698574
##########
mkdocs/docs/configuration.md:
##########
@@ -74,6 +74,7 @@ For the FileIO there are several configuration options
available:
| s3.signer | bearer | Configure the signature
version of the FileIO.
|
| s3.region | us-west-2 | Sets the region of the
bucket
|
| s3.proxy-uri | http://my.proxy.com:8080 | Configure the proxy server
to be used by the FileIO.
|
+| s3.connect-timeout | 60 | Configure socket
connection timeout, in seconds.
|
Review Comment:
Since it is a decimal, should we suggest this in the docs as well:
```suggestion
| s3.connect-timeout | 60.0 | Configure socket
connection timeout, in seconds.
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
