jqin61 commented on PR #218: URL: https://github.com/apache/iceberg-python/pull/218#issuecomment-1861741283
> This looks good @jqin61 Thanks for adding this. > > One minor thing I noticed is that s3fs is looking for an int, while pyarrow expects a double. Can you check for s3fs the type, and if it is not an `int`, emit a warning and cast it to an int (because we lose precision). Hi Fokko thank you for the review and comment! I tracked functions underneath s3fs filesystem initiation call and it seems the input could be float or int from this [doc](https://github.com/boto/botocore/blob/develop/botocore/config.py#L47). I also did a test to verify: ``` from s3fs import S3FileSystem S3FileSystem(config_kwargs=dict(connect_timeout=12.2)).config_kwargs {'connect_timeout': 12.2} ``` So it looks like we do not need to do the warning. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
